juicer icon indicating copy to clipboard operation
juicer copied to clipboard

Fixes parsing of invalid UTF-8 characters

Open ce-manalang opened this issue 11 years ago • 3 comments

Followed advice from http://stackoverflow.com/a/8873922

ce-manalang avatar Jul 17 '13 07:07 ce-manalang

So this basically ignores invalid utf-8 characters? Wouldn't it be better to fix them in the source files?

cjohansen avatar Jul 19 '13 09:07 cjohansen

@cjohansen yes we can fix the source files but if we want to juice a lot of js files with too many invalid chars, we have to go through them one by one.

Is it a good compromise if we just add a warning while juicing a file with invalid chars that those chars will be ignored? That way, juicing problematic files won't error out but it will not just silently juice.

Thoughts?

ce-manalang avatar Jul 29 '13 08:07 ce-manalang

Warnings are a good compromise :)

cjohansen avatar Jul 30 '13 21:07 cjohansen