node-cmake icon indicating copy to clipboard operation
node-cmake copied to clipboard

Added support for electron beta versions

Open WolverinDEV opened this issue 7 years ago • 1 comments

The current file regex does not support electron beta builds. This pr should fix this :)

An example:

find_package(NodeJS)

set(NODEJS_URL "https://atom.io/download/atom-shell")
set(NODEJS_VERSION "v4.0.0-beta.7")
nodejs_init()

WolverinDEV avatar Nov 09 '18 21:11 WolverinDEV

The problem with this is beta is part of the version and its variable. For instance, there's nightly builds of electron that use "nightly" where this PR won't work anymore.

computerquip-streamlabs avatar Dec 03 '18 21:12 computerquip-streamlabs