libsvm icon indicating copy to clipboard operation
libsvm copied to clipboard

Published 20 hours ago • verified publisher icon cjlin1

Added support for cache size > 2000

Open dalmia opened this issue 8 years ago • 3 comments

Fixes #80

This PR replaces long int with long long to support cache_size>2000.

Also, mentioned at scikit-learn/scikit-learn#8012

dalmia avatar Dec 20 '16 11:12 dalmia

If the compiler being used is DevStudio don't the supporting/calling methods need to be modified as well. int get_data(const int index, Qfloat **data, int len); The int data type in this instance is still 4 bytes. To access additional cache size these also need to be 64 bit data types (--int64 / long long) Does this effect building a 32 bit version with DevStudio?

TCharnley avatar Jan 02 '17 22:01 TCharnley

@TCharnley Yes, this is indeed a confusion for me too. I think we should wait for someone to answer that.

dalmia avatar Jan 04 '17 03:01 dalmia

Shouldn't this be size_t https://github.com/cjlin1/libsvm/issues/80#issuecomment-280381812 ?

amueller avatar Mar 04 '17 01:03 amueller