liblinear icon indicating copy to clipboard operation
liblinear copied to clipboard
verified publisher icon cjlin1

Makefile should use CXXFLAGS when calling CXX

Open ryandesign opened this issue 7 years ago • 0 comments

The Makefile passes $(CFLAGS) to $(CXX). It should pass $(CXXFLAGS) instead.

Furthermore, it defines its own CFLAGS, rather than honoring flags the user might supply when invoking make. This causes the build to fail if the user wants to supply flags that are required for the build to succeed.

This was discovered because liblinear is included in nmap. See the nmap bug report here: https://github.com/nmap/nmap/issues/1161 and the MacPorts project's bug report here: https://trac.macports.org/ticket/53995

ryandesign avatar Mar 27 '18 08:03 ryandesign