Chris LaRose

Results 39 comments of Chris LaRose

It looks like the compilation errors are happening when trying to compile the libargon2 source. I'd start by trying to upgrade `libargon2` as well. It's a submodule in this project,...

Ah, okay. It might be an issue in the `libargon2` source then. I'd try cloning their repo at https://github.com/P-H-C/phc-winner-argon2 and seeing if you're able to compile the project (`make` should...

Googlin' around seems to indicate that the `mmintrin.h` header file (which appears to be where the errors originate) is for working with x86-specific intrinsics (mmx instructions). I think what might...

I like the idea of adding this as an option. I understand a lot of people depend on the 0.0.0.0 for being to access puma from VMs or stuff like...

It's already possible to pass an arbitrary `Hash` to `Settings.add_source!`, so the new feature suggestion seems redundant, unless I'm misunderstanding it. Seems like you can just add the new top-level...

@wwboynton Makes sense. `reload` depends on calling `load` for all of the sources and since the `Hash` is unmodified, the workaround I suggested doesn't work for with `reload`ing. The suggestion...

I'm open to a PR with this change. I'll likely bump the major version, though, since it's possible someone is implicitly depending on the `Hash` monkey patch in their application.

@manjunath724 If I understand the feature request correctly, this can be replicated with the following spec: ```diff diff --git a/spec/config_env_spec.rb b/spec/config_env_spec.rb index 65e7da8..5f91def 100644 --- a/spec/config_env_spec.rb +++ b/spec/config_env_spec.rb @@ -77,6...

> @cjlarose will you have some time to look into this one? Yep! I can take a look this week.