cjee21

Results 321 comments of cjee21

With the latest version commit, both engines are even more identical for HTML view. | Theme | WebView2 | IE | | - | - | - | | Light...

Some more updates to prevent breaking anything. Should be all okay now. Should be safe to merge even before updating Graph template (just dark view will not work for Graph)....

Graph view is displaying differently at high DPI. No idea why as the same HTML+SVG is displayed the same in Firefox regardless of DPI. | 100% | 150% | |...

This PR should now be build-able and merge-able.

> @cjee21 please rebase. Of course I will. Another day for this as requires looking though and it is getting late.

@JeromeMartinez Re-based with fresh commits. Updated first post with details.

This PR and 64-bit PRs are independent but when this is merged, 64-bit PR has to be re-based with edits because installer/packaging will have to handle 64-bit version of `WebView2Loader.dll`.

> Graph view is displaying differently at high DPI. No idea why as the same HTML+SVG is displayed the same in Firefox regardless of DPI. Think I found the cause....

Looked into this a little: The division by zero occurs at: https://github.com/MediaArea/MediaInfoLib/blob/f24a17b415eca1f37cf7b75d120634173ff3131e/Source/MediaInfo/Audio/File_Aac_GeneralAudio_Sbr.cpp#L767 Value of `sampling_frequency` is propagated though a few functions from where it is assigned zero at: https://github.com/MediaArea/MediaInfoLib/blob/f24a17b415eca1f37cf7b75d120634173ff3131e/Source/MediaInfo/Audio/File_Usac.cpp#L5072 This...

Fixed by https://github.com/MediaArea/MediaInfoLib/commit/c28ae12b4d8d89d547ed066f54561a20de4e07e0.