constexpr-contracts icon indicating copy to clipboard operation
constexpr-contracts copied to clipboard
verified publisher icon cjdb

Optimize and add ability to configure error printing function

Open rayhamel opened this issue 4 years ago • 4 comments

As mentioned in the original PR #9 , fixes a potential issue when the user has called std::ios_base::sync_with_stdio(false)

rayhamel avatar May 31 '21 01:05 rayhamel

Thanks for splitting this into multiple commits. Before approving, I'd like to see a few tests and the documentation updated, to demonstrate the new usage.

I added tests and a section to the documentation. Thanks for the feedback and your time.

rayhamel avatar Jun 01 '21 00:06 rayhamel

Thanks for your patience @rayhamel. I wanted a bit of time to think over your comments, but I've been very preoccupied recently. I'll get to this as soon as I can.

cjdb avatar Jun 06 '21 19:06 cjdb

Thanks for your patience @rayhamel. I wanted a bit of time to think over your comments, but I've been very preoccupied recently. I'll get to this as soon as I can.

Absolutely no rush! Thanks again for your time.

rayhamel avatar Jun 07 '21 15:06 rayhamel

Hi @rayhamel, to jog my memory on this PR (and the next one), your goal here is to add ostream support, right?

cjdb avatar Feb 18 '22 20:02 cjdb