Missing Protections for Fish Bucket Placement

Open cjburkey01 opened this issue 4 years ago • 2 comments

Check for new spigot events to listen to

Jul 28 '21 04:07 cjburkey01

I think this can be handled by the PlayerInteractEvent

Jul 28 '21 08:07 Goldmensch

I think this can be handled by the PlayerInteractEvent

Do you know how to implement this? I added a handler for PlayerBucketEntityEvent in https://github.com/cjburkey01/ClaimChunk/commit/b7201d3c35246e430f3030c79712a1fa7f3b9d6a but if this is handled by the PlayerInteractEvent, shouldn't it be handled by this handler?

I'm going to have a better look at this mess of a function. I don't want to have to handle by making sure it's a fish bucket because I feel like that would lead to a bunch of compatibility problems if they ever change, especially across versions.

Aug 08 '21 20:08 cjburkey01