react-native-spotify-remote icon indicating copy to clipboard operation
react-native-spotify-remote copied to clipboard

Published 20 hours ago • verified publisher icon cjam

feat: upgrade Android Auth library to 2.0.2

Open wwdrew opened this issue 3 years ago • 2 comments
trafficstars

Fixes #209 .

Changes introduced in this pull request:

  • Update SpotifySDK submodule to latest commit
  • Update build.gradle to import auth-lib from maven
  • Remove clearCookies method call as this no longer exists in new SDK

Tasks

  • [x] Add yourself as contributor via yarn contribute
  • [x] Update Unreleased section of CHANGELOG.md with changes (Convention)

@cjam

Please note I'm having problems testing this change so there's a high chance it doesn't work. However, everything in Android Studio is saying it's okay so I'm hopeful it should work. I just couldn't get a package to build I could import into my project to make sure.

wwdrew avatar Aug 12 '22 12:08 wwdrew

Awesome thanks for the PR! sorry for the delay, I've been underwater at work. I will try and merge and test it as soon as I can.

cjam avatar Aug 22 '22 12:08 cjam

Hi @cjam, no worries I know exactly how it feels :)

I've managed to move this PR forward a little testing-wise and there's still some more work to be done on it, Spotify's changed a few things in the move from v1 -> v2 of the auth sdk that I'm trying to integrate properly.

I've also taken this comment (https://github.com/cjam/react-native-spotify-remote/issues/203) into consideration and changed how the auth-sdk is imported, as it's the only way to get v2.0.2.

I should probably mark this PR as WIP until I've got it sorted really.

wwdrew avatar Aug 22 '22 16:08 wwdrew