Chris Jakeman

Results 38 comments of Chris Jakeman

Hi Cesar, Now that your PR 627 Improve advanced adhesion model is in the Testing Version, what is the situation with this one? Is it ready to go back into...

OK, thanks. Hope you and Peter can come up with something that's close enough.

> I am starting the PR with the not-for-unstable label because it will likely conflict with https://github.com/openrails/openrails/pull/569 until that one is merged. #569 was merged a few days ago :-)

> For the first refactoring I have chosen a couple of small parts: animated couplers and animated air hoses Comparing "before" and "after" is going to be interesting. Hoping to...

Hi Peter, @pzgulyas > However I'm not sure how to resolve it at this stage. I cannot commit the fix into either of the PRs, because then that could not...

Hi Peter, @pzgulyas > I am happy to approve PR 538 PR 538 is now approved and merged into the master branch. You should be able to update your local...

> Conflict resolved, back on track. That's great. I see the PR has made it into the Unstable build. In trying things out, I came across a case which vfs.FileExists()...

> Are you using the version later than the commit [efffead](https://github.com/openrails/openrails/commit/efffead3c1179acbb58d921675fff69c189334f0) ? I've added that specifically to flatten such paths to avoid browsing the imaginary directories, like probably the "CABVIEW"...

> Hi Chris, @cjakeman, My bad, I should have thought of testing it with our own test asset. :-) Not your mistake, Péter, but mine. I didn;t start from your...

Hi Peter, > The AppVeyor builds it correctly, and the problem is only on the other server, so I need to go with trial-and-error method, which is impossible if the...