C.J. Collier
C.J. Collier
This is another action without tests. Should we add tests or remove the action? Since we do have documentation[1] about the init action, perhaps it is best to add the...
no bazel tests for this action: ``` 2024-02-23T19:50:00.272592904Z + bazel test --jobs=10 --local_test_jobs=10 --flaky_test_attempts=3 --action_env=INTERNAL_IP_SSH=true --test_output=errors --noshow_progress --noshow_loading_progress --test_arg=--image_version=1.5-ubuntu18 :test_user_environment 2024-02-23T19:50:00.318937577Z Extracting Bazel installation... 2024-02-23T19:50:08.775690454Z Starting local Bazel server and...
Might as well copy the tar.gz packages from archive.apache.org as well. They're flakey to download.
Yes, I will get to it eventually, but if you supply your tested patch, my efforts can be better spent by reviewing your change and merging it in.
Well, yes, and... do we want to support the situation where customers are running[1] in a container that doesn't have access to `gcloud storage` still? Would it make sense to...
Okay, please review #112 ; once you have confirmed that this patch doesn't break your use case, I'll merge.
Hello John, I'm finishing up the review now. Can you confirm that the code from #112 , now updated to fix issues Chris found, continues to work in your environment?
Thank you! I'll get a PR opened shortly.
I think this was fixed with #1205