cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon civo

Issue-231 Fixed no Instances found

Open kitarp29 opened this issue 2 years ago • 5 comments

  • #231 Hi @kaihoffman this is an easy and quick fix for the issue. I wanted to break the loop in the length of the array is zero. But I am concerned about the common.OutputFormat condition . Please review and let me know of the changes. Signed-off-by: kitarp29 [email protected]

kitarp29 avatar Aug 20 '22 16:08 kitarp29

Yes @alejandrojnm as I mentioned in my first message I knew that the rest of the code did not make sense to execute if len(instance)==0. So should I commit the changes you mentioned or just add a break at the end of my code snippet? cc: @kaihoffman

kitarp29 avatar Aug 20 '22 20:08 kitarp29

@kitarp29 thanks for the PR :)

RealHarshThakur avatar Aug 23 '22 18:08 RealHarshThakur

We need to keep a standard in all the code, we can use println in some place and in others use utility.Info

alejandrojnm avatar Aug 23 '22 21:08 alejandrojnm

Good point @alejandrojnm . We should move to a well-maintained logging package at some point like @kitarp29 pointed out in this issue. https://github.com/civo/cli/issues/233

RealHarshThakur avatar Aug 23 '22 21:08 RealHarshThakur

@alejandrojnm Do we want to hold this off until we resolve the logging issue?

RealHarshThakur avatar Aug 24 '22 10:08 RealHarshThakur