cli icon indicating copy to clipboard operation
cli copied to clipboard

Logging Setup

Open kitarp29 opened this issue 2 years ago • 7 comments

I was looking towards to contributing to the project. I can't seem to find any kind of Logging setup in the project. Not a pro in Golang but surely have worked around log module and logrus module. I know the benefits of logs. It helps a lot while debugging. If this is something viable to be added to the project. Please assign it to me :) cc: @andyjeffries @DMajrekar @jaysonsantos

kitarp29 avatar Jun 27 '22 19:06 kitarp29

@RealHarshThakur @alejandrojnm If logrus seems like a good fit let me. It has different categories for Logs and will come in real handy if you have any logging architecture setup with something like Fluentd or ELK stack A good article on the same Here

kitarp29 avatar Aug 24 '22 04:08 kitarp29

I'm more than happy to use logrus

alejandrojnm avatar Aug 24 '22 07:08 alejandrojnm

If this is something that is needed. assign me to the issue, I will start working on it during the weekend.

kitarp29 avatar Aug 24 '22 07:08 kitarp29

Thanks for assiting with this @kitarp29
We'll need to make sure that our outputs are consistent from UX though. Shout out to us if you need help

RealHarshThakur avatar Aug 24 '22 10:08 RealHarshThakur

@kitarp29 it will be nice if we can run in debug mode like kubectl that shows all the trace if you pass -v 10, in that way we can debug every query made by the CLI

alejandrojnm avatar Aug 24 '22 10:08 alejandrojnm

For the initial PR though, happy to just see it be a drop-in replacement for what we have right now.

RealHarshThakur avatar Aug 24 '22 10:08 RealHarshThakur

Yes, @RealHarshThakur I will be making smaller commits itself so that it will be easier for the maintainers to review it.

kitarp29 avatar Aug 24 '22 14:08 kitarp29

@kitarp29 Can i take this forward?

uzaxirr avatar Oct 28 '22 04:10 uzaxirr

@uzaxirr I am stuck with some work in life. Surely you can take this forward. If you have any trouble understanding the approach I took, do let me know. I will help you in understanding. The implementation is pretty straightforward, just replicate the work over other functions.

kitarp29 avatar Oct 28 '22 04:10 kitarp29

@uzaxirr I am stuck with some work in life. Surely you can take this forward. If you have any trouble understanding the approach I took, do let me know. I will help you in understanding. The implementation is pretty straightforward, just replicate the work over other functions.

Sure thing!

uzaxirr avatar Oct 28 '22 08:10 uzaxirr

@RealHarshThakur Can you assign this to me.

uzaxirr avatar Oct 29 '22 17:10 uzaxirr