muffnn icon indicating copy to clipboard operation
muffnn copied to clipboard

Travis CI builds don't pass with master branch anymore

Open jacksonllee opened this issue 5 years ago • 3 comments

Curiously, the master branch (updated about two months ago) has had the builds all passed, while the exact same code now apparently cannot pass the builds. The test failures are due to two estimator checks (autoencoder and MLP classifier) not passed. The environments (packages, etc.) should be identical between two months and this week, but maybe there's something we've overlooked.

I came across this while investigating why the builds didn't pass at #101.

jacksonllee avatar Feb 12 '20 22:02 jacksonllee

any updates on this? would really like to get that tensorflow security PR merged in.

https://github.com/civisanalytics/muffnn/pull/101

--timball

timball avatar Mar 17 '20 13:03 timball

Hey @timball I'll take a look at this issue.

salilgupta1 avatar Mar 27 '20 15:03 salilgupta1

#103 fixed the build, but I think we should leave this open since I fixed it by skipping part of scikit-learn's check_estimator function (see the PR for details). It'd be nice to solve that in a cleaner way eventually.

mheilman avatar Apr 06 '20 15:04 mheilman