CTI-website-frontend
CTI-website-frontend copied to clipboard
Update landing page (#909)
Closes #909
-
Update Google Analytics measurement ID
-
Update root route to point to homepage
-
Simplify Layout
-
Update breadcrumbs to use root route
-
Update spec files to use root route
-
Remove references to old landing page
On cypress/fixtures/faqs.json file you have changed the a href to "[http://civictechindex.org](http://civictechindex.org%5C)" But on FAQ page on What is Civic Tech Index? On clicking on Civic Tech Index hyperlink , it still goes to "http://civictechindex.org/home" page
@bhaggya faqs.json is for testing. If you go the FAQ page, then it currently calls the production backend API. That data returned by the API still has the old homepage URL. You can verify this by fetching the raw JSON in your browser with the following URL: https://api.civictechindex.org/api/faqs/
On cypress/fixtures/faqs.json file you have changed the a href to "http://civictechindex.org" But on FAQ page on What is Civic Tech Index? On clicking on Civic Tech Index hyperlink , it still goes to "http://civictechindex.org/home" page
@bhaggya faqs.json is for testing. If you go the FAQ page, then it currently calls the production backend API. That data returned by the API still has the old homepage URL. You can verify this by fetching the raw JSON in your browser with the following URL: https://api.civictechindex.org/api/faqs/
I didnt know that ,the API needs to be changed
@ladissi we will most likely need to update some data in the production db that are still referring to the /home route since that should no longer exist.
This is purely code style preferences: I noticed several files are inconsistent with ordering of keys in their breadcrumb links. (Ex.)
{ href: '/', name: 'Home' } vs { name: 'Home', href: '/' }
It could be nice to change them to one standardized style, it seems like more files use the "name, href" format as of right now. If it's not that critical, we can forgo this for a later issue.
This is purely code style preferences: I noticed several files are inconsistent with ordering of keys in their breadcrumb links. (Ex.)
{ href: '/', name: 'Home' } vs { name: 'Home', href: '/' }
It could be nice to change them to one standardized style, it seems like more files use the "name, href" format as of right now. If it's not that critical, we can forgo this for a later issue.
Good catch. I cleaned up the breadcrumb objects so href comes first
Code Climate has analyzed commit 5914d400 and detected 3 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Duplication | 3 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 80.9% (0.0% change).
View more on Code Climate.