citus icon indicating copy to clipboard operation
citus copied to clipboard

Do not remove totaltime instrumentation from queryDesc

Open Green-Chan opened this issue 6 months ago • 1 comments

Previous approach could have caused problems with other extensions that are using queryDesc->totaltime during query execution. Use another way to count the time used before postgres' executor.

Green-Chan avatar Jun 23 '25 15:06 Green-Chan

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (5deaf9a) to head (6e35220).

:exclamation: There is a different number of reports uploaded between BASE (5deaf9a) and HEAD (6e35220). Click for more details.

HEAD has 77 uploads less than BASE
Flag BASE (5deaf9a) HEAD (6e35220)
17_regress_check-pytest 1 0
16_regress_check-pytest 1 0
15_citus_upgrade 1 0
15_regress_check-pytest 1 0
15_17_upgrade 1 0
15_16_upgrade 1 0
16_regress_check-follower-cluster 1 0
15_regress_check-columnar-isolation 1 0
16_regress_check-columnar-isolation 1 0
17_regress_check-follower-cluster 1 0
15_regress_check-follower-cluster 1 0
17_regress_check-columnar-isolation 1 0
16_17_upgrade 1 0
15_regress_check-columnar 1 0
16_regress_check-query-generator 1 0
15_regress_check-enterprise-isolation-logicalrep-2 1 0
16_regress_check-enterprise-isolation-logicalrep-3 1 0
16_regress_check-enterprise-isolation-logicalrep-2 1 0
17_regress_check-columnar 1 0
15_regress_check-split 1 0
17_regress_check-enterprise-isolation-logicalrep-3 1 0
17_regress_check-enterprise-isolation-logicalrep-2 1 0
16_regress_check-columnar 1 0
16_regress_check-enterprise-failure 1 0
15_regress_check-enterprise-failure 1 0
15_regress_check-query-generator 1 0
15_regress_check-enterprise-isolation-logicalrep-3 1 0
15_regress_check-enterprise-isolation-logicalrep-1 1 0
17_regress_check-enterprise-isolation-logicalrep-1 1 0
15_arbitrary_configs_3 1 0
16_cdc_installcheck 1 0
17_cdc_installcheck 1 0
15_cdc_installcheck 1 0
17_regress_check-operations 1 0
15_regress_check-operations 1 0
16_arbitrary_configs_5 1 0
16_regress_check-isolation 1 0
16_arbitrary_configs_2 1 0
15_regress_check-isolation 1 0
17_arbitrary_configs_2 1 0
17_regress_check-isolation 1 0
15_regress_check-multi 1 0
16_regress_check-multi 1 0
17_regress_check-multi 1 0
17_regress_check-enterprise-isolation 1 0
15_arbitrary_configs_0 1 0
17_arbitrary_configs_3 1 0
15_regress_check-failure 1 0
16_regress_check-failure 1 0
16_regress_check-operations 1 0
17_arbitrary_configs_5 1 0
15_arbitrary_configs_5 1 0
15_arbitrary_configs_2 1 0
16_regress_check-multi-1 1 0
17_regress_check-multi-1 1 0
15_regress_check-multi-1 1 0
15_arbitrary_configs_4 1 0
16_arbitrary_configs_4 1 0
16_arbitrary_configs_0 1 0
17_arbitrary_configs_0 1 0
17_arbitrary_configs_4 1 0
15_arbitrary_configs_1 1 0
17_regress_check-enterprise-failure 1 0
17_regress_check-split 1 0
17_regress_check-query-generator 1 0
15_regress_check-vanilla 1 0
16_regress_check-split 1 0
16_regress_check-enterprise 1 0
15_regress_check-enterprise 1 0
16_regress_check-vanilla 1 0
17_regress_check-enterprise 1 0
16_arbitrary_configs_3 1 0
17_regress_check-vanilla 1 0
16_regress_check-enterprise-isolation 1 0
15_regress_check-enterprise-isolation 1 0
16_arbitrary_configs_1 1 0
17_arbitrary_configs_1 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8029       +/-   ##
===========================================
- Coverage   89.19%   62.97%   -26.23%     
===========================================
  Files         284      284               
  Lines       61515    61289      -226     
  Branches     7696     7641       -55     
===========================================
- Hits        54871    38594    -16277     
- Misses       4440    19855    +15415     
- Partials     2204     2840      +636     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 23 '25 16:06 codecov[bot]