citusdata
Added ability to build with warning - control reaches end of non-void function Werror=return-type"
We have a product where the warning Werror=return-type is enabled and is treated as an error for the entire build process. So our build process stops. Of course, we can do tricks in the build script, but I guess this commit will be useful because it removes one excluded warning.
@microsoft-github-policy-service agree company="Sbertech" @microsoft-github-policy-service agree
@hanefi @thanodnl
This pull request stopped my work on the main product - I can't modify the Citus sources in the project I am working on currently. Do you think it's possible to merge this pull request into the main branch?
Also, I didn't know how the review process is organized in Citus project.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 49.04%. Comparing base (
c52f360) to head (29f7d02). Report is 2 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (c52f360) and HEAD (29f7d02). Click for more details.
HEAD has 151 uploads less than BASE
Flag BASE (c52f360) HEAD (29f7d02) 14_regress_check-pytest 2 0 _upgrade 30 1 15_regress_check-follower-cluster 2 0 14_regress_check-columnar-isolation 2 0 14_regress_check-follower-cluster 2 0 16_regress_check-pytest 2 0 15_regress_check-pytest 2 0 15_regress_check-query-generator 2 0 14_16_upgrade 2 0 15_regress_check-enterprise-isolation-logicalrep-3 2 0 16_regress_check-query-generator 2 0 16_regress_check-follower-cluster 2 0 15_regress_check-enterprise-isolation-logicalrep-2 2 0 15_regress_check-columnar-isolation 2 0 14_regress_check-enterprise-isolation-logicalrep-3 2 0 16_regress_check-columnar-isolation 2 0 16_regress_check-enterprise-isolation-logicalrep-3 2 0 15_regress_check-columnar 2 0 14_regress_check-split 2 0 14_regress_check-columnar 2 0 15_regress_check-split 2 0 14_regress_check-enterprise-failure 2 0 15_regress_check-multi-mx 2 0 15_regress_check-enterprise 2 0 15_regress_check-enterprise-isolation-logicalrep-1 2 0 14_regress_check-enterprise-isolation-logicalrep-1 2 0 16_regress_check-enterprise-isolation 2 0 16_regress_check-enterprise-isolation-logicalrep-1 2 0 14_regress_check-enterprise 2 0 16_cdc_installcheck 2 0 15_cdc_installcheck 2 0 14_regress_check-query-generator 2 0 16_regress_check-enterprise-failure 2 0 14_regress_check-enterprise-isolation-logicalrep-2 2 0 14_regress_check-operations 2 0 16_regress_check-failure 2 0 14_regress_check-multi-mx 2 0 16_regress_check-multi-mx 2 0 14_regress_check-failure 2 0 15_regress_check-failure 2 0 15_regress_check-enterprise-isolation 2 0 15_regress_check-vanilla 2 0 16_regress_check-enterprise-isolation-logicalrep-2 2 0 14_15_upgrade 2 0 16_regress_check-columnar 2 0 15_regress_check-isolation 2 0 16_regress_check-isolation 2 0 14_regress_check-isolation 2 0 14_regress_check-multi 2 0 15_regress_check-multi 2 0 16_regress_check-multi 2 0 15_regress_check-multi-1 1 0 14_regress_check-multi-1 1 0 16_regress_check-multi-1 2 0 15_regress_check-operations 2 0 16_regress_check-operations 2 0 16_regress_check-vanilla 2 0 15_16_upgrade 2 0 16_regress_check-enterprise 2 0 15_regress_check-enterprise-failure 2 0 14_regress_check-enterprise-isolation 2 0 14_regress_check-vanilla 2 0 16_regress_check-split 2 0
Additional details and impacted files
@@ Coverage Diff @@
## main #7680 +/- ##
===========================================
- Coverage 89.69% 49.04% -40.65%
===========================================
Files 283 282 -1
Lines 60510 59501 -1009
Branches 7541 7313 -228
===========================================
- Hits 54276 29185 -25091
- Misses 4079 27699 +23620
- Partials 2155 2617 +462
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}