citus icon indicating copy to clipboard operation
citus copied to clipboard

Fix parameter resolving issues with procedure calls when auto_explain is enabled.

Open emelsimsek opened this issue 9 months ago • 1 comments

There are two ways to generate explain resullts:

  1. Run the EXPLAIN command with query
  2. Turn on auto_explain, to quitely explain queries in the logs.

Citus follows different code paths in those two cases.

It runs out that auto_explain code path cannot handle parameters to procedures when explaining the procedure calls.

I am not highly confident in this change, expecially the part where I had to skip parameters with type 0, to make the code work, but the solution should be similar to this.

emelsimsek avatar May 13 '24 12:05 emelsimsek

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.70%. Comparing base (553d5ba) to head (2b520fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7598   +/-   ##
=======================================
  Coverage   89.69%   89.70%           
=======================================
  Files         283      283           
  Lines       60506    60510    +4     
  Branches     7538     7539    +1     
=======================================
+ Hits        54270    54279    +9     
+ Misses       4081     4077    -4     
+ Partials     2155     2154    -1     

codecov[bot] avatar May 13 '24 12:05 codecov[bot]