citus icon indicating copy to clipboard operation
citus copied to clipboard

Adds support for granted by propagation for grant statements without filtering non-distributed roles

Open gurkanindibay opened this issue 1 year ago • 1 comments

This is related to #7538. In this PR, non-distributed roles are not being filtered when executing grant statements and sending grant statements in metadata sync. According to the requirements that @JelteF expressed, most of the time non distributed roles exists in all nodes but they are not marked as distributed in pg_dist_object.

Either this PR or #7538 should be accepted. Please evaluate both PR's together and be aware that just one of them will be merged

gurkanindibay avatar Mar 12 '24 06:03 gurkanindibay

Codecov Report

Merging #7558 (9874a07) into main (8afa2d0) will decrease coverage by 0.07%. The diff coverage is 66.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7558      +/-   ##
==========================================
- Coverage   89.69%   89.63%   -0.07%     
==========================================
  Files         282      282              
  Lines       60462    60525      +63     
  Branches     7530     7539       +9     
==========================================
+ Hits        54233    54251      +18     
- Misses       4078     4118      +40     
- Partials     2151     2156       +5     

codecov[bot] avatar Mar 12 '24 07:03 codecov[bot]