citus icon indicating copy to clipboard operation
citus copied to clipboard
verified publisher icon citusdata

Add CI job for checking missing downgrade scripts

Open hanefi opened this issue 5 years ago • 1 comments

This is a CI script to make sure if citus--X--Y.sql is updated on a branch, citus--Y--X.sql should be updated as well. Thus making all future schema changes to be coupled with appropriate downgrade scripts.

When working on #3927 we discussed the idea for a CI check for making sure we create downgrade scripts in the future whenever we introduce some schema changes in a migration script. However #3927 introduces only downgrade scripts that does not check the tests there.

Related: https://github.com/citusdata/citus/pull/3927#issuecomment-647577494 https://github.com/citusdata/citus/pull/3927#issuecomment-647588980

hanefi avatar Jun 25 '20 10:06 hanefi

I created this PR https://github.com/citusdata/citus/pull/3958. So, it would be nice if you could write a doc section on this script too.

JelteF avatar Jun 30 '20 17:06 JelteF

@hanefi do you think we still need this? It sounds useful if we have not already doing that.

If not needed, can you please close the PR? Thanks!

onderkalaci avatar Oct 21 '22 14:10 onderkalaci