spree_variant_options icon indicating copy to clipboard operation
spree_variant_options copied to clipboard

Published 20 hours ago • verified publisher icon citrus

adapted for Spree 2

Open Numerico opened this issue 11 years ago • 7 comments

Hello, I used your extension in a Spree 2.0.4 project so had to adapt it to work with it. I would say the main changes were to move count_on_hand and backorderable from products and variants down to stock items. I've got all tests passing and features green in this commit.

I would be available to discuss any comments if needed. Thanks

Numerico avatar Oct 03 '13 19:10 Numerico

Hey @Numerico thanks for the PR!! I'll check it out tonight and merge it if all the tests are passing! :+1:

citrus avatar Oct 04 '13 00:10 citrus

all right, just FYI you can notice the first commits were for Spree 1.2.5 (see https://github.com/Numerico/spree_variant_options/tree/spree_1.2.5, that branch has got test unit passing, but not all of cucumber's) this would be the first commit for Spree 2 https://github.com/Numerico/spree_variant_options/commit/60f4a043a8190ec0a58b0545b97073a373f9f677

Numerico avatar Oct 04 '13 23:10 Numerico

@Numerico Is this working?

paynecodes avatar Nov 25 '13 06:11 paynecodes

yeah, you should be able to run the tests with

bundle exec rake

Numerico avatar Nov 25 '13 13:11 Numerico

Awesome! Thank you.

paynecodes avatar Nov 26 '13 06:11 paynecodes

Is this going to become a 2-1-stable branch for use with Spree 2.1?

jhirbour avatar Dec 23 '13 20:12 jhirbour

Hopefully, shouldn't change much from 2.0.4 to 2.1, should it?

Numerico avatar Dec 27 '13 01:12 Numerico