terraform-provider-citrixadc icon indicating copy to clipboard operation
terraform-provider-citrixadc copied to clipboard

New Resource: cmpglobal_cmppolicy_binding

Open brittandeyoung opened this issue 2 years ago • 3 comments

Adding a new resource for globally binding cmppolicy resource.

Closes: #650

brittandeyoung avatar Jul 25 '22 13:07 brittandeyoung

This DCO check is complaining about ownership of a commit that I brought from the master branch to resolve a conflict. I am not sure how to resolve this.

Also Is anyone aware of how to run acctests against a netscaler that does not have a valid certificate? I have a local netscaler that I used when writing and validating this resource, but was unable to run the acctests against it as the certificate is not valid (as expected since its a local VM).

brittandeyoung avatar Jul 25 '22 15:07 brittandeyoung

I as able to run my acceptance tests over http:

make testacc TESTARGS='-run=TestAccCmppolicy_global_binding_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccCmppolicy_global_binding_basic -timeout 120m
?   	github.com/citrix/terraform-provider-citrixadc	[no test files]
2022/07/25 12:01:39 [DEBUG]  citrixadc-provider-test: In init
2022/07/25 12:01:39 [DEBUG]  citrixadc-provider-test: In isTargetAdcCluster
2022/07/25 12:01:39 Helper client instantiated
=== RUN   TestAccCmppolicy_global_binding_basic
--- PASS: TestAccCmppolicy_global_binding_basic (4.22s)
PASS
ok  	github.com/citrix/terraform-provider-citrixadc/citrixadc	4.936s

Still not sure how to resolve the DCO test, I have followed the steps mentioned as a fix.

brittandeyoung avatar Jul 25 '22 16:07 brittandeyoung

I Figured out the DCO check, there was a commit to resolve the merge conflict that was missing the sing off commit message.

brittandeyoung avatar Jul 26 '22 13:07 brittandeyoung