Issues with Ocarina of Time 3D local multiplayer

[Kewlan]

1. When creating a network with too many nodes allowed, in this example 16, Citra will crash. Right now we've reduced the max players on Citra to 8, which works. citra_log.txt Mod files that open a network for 16 players: 0004000000033500.zip

[  20.209198] Debug <Critical> core/hle/service/nwm/uds_beacon.cpp:operator():281: Assertion Failed!
Data is too big.

2. When a client restarts their game they're not properly kicked from the existing network, and rejoining will fail. A temporary workaround is to rejoin the Citra lobby, but since this doesn't reduce the existing players it'll only work until the max players have been reached. citra_log.txt Mod files that limit players to 8: 0004000000033500.zip

[  28.414937] Service.NWM <Error> core/hle/service/nwm/nwm_uds.cpp:HandleAuthenticationFrame:445: Connection sequence aborted, because there is already a connected client with that MAC-Adress

Neither of these issues happen on console. This mod has a custom menu that can be opened with select after having loaded into a save, which shows how many players are connected. The mod only works for the USA version. The mod files above were generated specifically for Citra. If anyone wants to test how it works on console, use these instead: 0004000000033500.zip The network creation/joining automatically happens at the title screen.

[Kewlan]

A bit late, but local multiplayer is now available in the Nightly builds which can be downloaded here: https://github.com/gamestabled/OoT3D_Randomizer/releases

When generating the mod files, make sure to enable multiplayer under the "Multiplayer Settings" sub-menu.

Here's the function that handles the local connection, and where the max players is reduced: https://github.com/gamestabled/OoT3D_Randomizer/blob/main/code/src/multiplayer.c#L376-L379