purescript-halogen-select icon indicating copy to clipboard operation
purescript-halogen-select copied to clipboard

Published 20 hours ago • verified publisher icon citizennet

update to v0.14

Open srghma opened this issue 5 years ago • 4 comments

What does this pull request do?

here are the changes to next-6 https://github.com/purescript-halogen/purescript-halogen/compare/next-6

How should this be manually tested?

I have this zsh function to link all my local projects

https://github.com/srghma/dotfiles/blob/f0e70f7357a477ece9afa3b78b83185988e3fda2/zsh/link-all-purescript-projects.sh#L1

Other notes

I dont want this pr to be merged now, I have created it just to test that it works with my hydration test project (that is rebased on next-6 as of now)

srghma avatar Jun 18 '20 08:06 srghma

@srghma Can you please fill out the PR template for future pull requests? It’s there so that the team here can get the gist of the changes before diving into the code. We can review your PRs and get them merged much faster if you help explain the motivation for changes and why they were done a certain way.

In this particular case you’re updating to Halogen 6, so you could just delete the PR template and say that.

I think it’s a bit premature to update given that Halogen 6 doesn’t have a release candidate yet and there may be more changes that require more updates to this library. Is there a particular reason you think the update should happen now?

If so you will also need to update the Spago files so the right version of Halogen is used. You’d need to override the package set to point at Halogen’s next-6 branch.

thomashoneyman avatar Jun 18 '20 17:06 thomashoneyman

@thomashoneyman updates

No, I dont want this pr to be merged now, I have created it just to test that it works with my hydration test project (that is rebased on next-6 as of now)

srghma avatar Jun 18 '20 17:06 srghma

I see. If you don’t want it merged, then can you use a fork of the library to test this instead of keeping a PR open here? Having the PR gives the sense that this is intended to be merged.

thomashoneyman avatar Jun 18 '20 17:06 thomashoneyman

can you use a fork of the library to test this instead of keeping a PR open here?

I thought you will be interested

I would leave it open until next-6 is released (I plan to keep up to date with next-6 and may update this pr later when new changes are introduced) I dont see a problem with lingering pr's

but yes, we can merge it to new branch next-6 or even close this

srghma avatar Jun 18 '20 17:06 srghma