test-lists
test-lists copied to clipboard
added missing country code
added missing country code of the Democratic Republic of the Congo, as the list contains only the code of the neighboring country with a similar name - the Republic of the Congo. They are two different countries.
Good call, though I actually wonder if we want to be keeping a list of iso alpha2 country codes to country names mappings inside of this repo.
@sneft @jakubd do you recall what the original reason to have these country codes in the repo was? Do you think it would be reasonable to drop this file from the repo and just document that the country codes are ISO 3166 alpha2.
I think if we point to a definitive external source for the country codes I have no problem removing this file. (I usually just google it myself, anyway)
I think the wikipedia page on ISO 3166 alpha2 and the official ISO standards code page are the most authoritative sources on this.
In relation to mapping the country codes to names automatically, this is something that is a bit more tricky to do (for example Taiwan is labeled by the ISO body as "Taiwan, Province of China"). I started this project: https://github.com/hellais/country-util to do that. Instead of the "official" ISO name of the countries, it uses the names from the Unicode Common Locale Data Repository (CLDR) Project, which is a bit more responsive to community input and has more sensible names for countries.
We can maybe link all three of these resources and then it's up to consumers of the data to make up their mind on how to resolve a country code to a name (which I think is beyond the scope of this repo).
@hellais May we merge this PR?