natives icon indicating copy to clipboard operation
natives copied to clipboard

Added params for `SETUP_FAKE_CONE_DATA`

Open PappaNiels opened this issue 2 years ago • 7 comments

This pull request will add some of the parameters of this native (which is still a hash). Can be used for cctv cams or maybe even guards.

PappaNiels avatar Jan 13 '23 17:01 PappaNiels

Did it in the correct 'style' as the native you mentioned. Should be good now :)

PappaNiels avatar Jan 15 '23 18:01 PappaNiels

Added the conversion for rad to deg and deg to rad and mentioned it for the param like thorium said

PappaNiels avatar Jan 16 '23 18:01 PappaNiels

Any update on if the latest changes have been approved and when it will be merged?

PappaNiels avatar Feb 15 '23 21:02 PappaNiels

Any update on if the latest changes have been approved and when it will be merged?

This looks good to me, I don't think it requires any other changes, at least from what I have seen here. I can't really give ETA's on merges though since I don't handle that, but if most reviewers approve, it will most likely get merged 🙂

4mmonium avatar Feb 19 '23 22:02 4mmonium

Ah ok. We will play the wait game then. Thanks for your response!

PappaNiels avatar Feb 22 '23 15:02 PappaNiels

This probably got lost in the sea of work. @4mmonium can you merge if everything's still good with this one?

thorium-cfx avatar Feb 28 '24 13:02 thorium-cfx

New reminder @4mmonium :) . Would be unfortunate if this research got lost.

PappaNiels avatar Apr 23 '24 19:04 PappaNiels

Hi, I'm merging this 😊

4mmonium avatar Jun 24 '24 01:06 4mmonium