natives icon indicating copy to clipboard operation
natives copied to clipboard

Updated lots of natives

Open BJDubb opened this issue 1 year ago • 4 comments

updated the following natives

AUDIO/PlaySoundFrontend.md AUDIO/SetAudioFlag.md
DECORATOR/DecorSetInt.md ENTITY/ApplyForceToEntity.md ENTITY/AttachEntityToEntityPhysically.md ENTITY/SetEntityLoadCollisionFlag.md ENTITY/SetEntityLodDist.md ENTITY/SetEntityProofs.md GRAPHICS/StartParticleFxLoopedAtCoord.md HUD/SetMinimapComponent.md OBJECT/AddExtendedPickupProbeArea.md OBJECT/N_0xd4a7a435b3710d05.md OBJECT/SetObjectPhysicsParams.md PATHFIND/GetRandomVehicleNode.md TASK/TaskCombatPed.md

BJDubb avatar Nov 05 '24 17:11 BJDubb

I'm not sure if the stance on batch updates remains the same, but from what I understand, they are not accepted due to PRs being time-consuming and prone to human error (to some degree).

#1048 (comment)

I would agree when changes are natives name changed, added params, etc, but here it's mostly descriptions and param descriptions added + re-formatted correctly. I wouldn't see why, this is (from the quick look) nice work and respecting all the signature from docs.

PsychoShock avatar Nov 05 '24 23:11 PsychoShock

I'm not sure if the stance on batch updates remains the same, but from what I understand, they are not accepted due to PRs being time-consuming and prone to human error (to some degree). #1048 (comment)

I would agree when changes are natives name changed, added params, etc, but here it's mostly descriptions and param descriptions added + re-formatted correctly. I wouldn't see why, this is (from the quick look) nice work and respecting all the signature from docs.

Yeah, looked further and it's mostly just parameter name changes and descriptions.

colistro123 avatar Nov 05 '24 23:11 colistro123

Thank you for the review @JayPaulinCodes

Waiting on some guidance about OBJECT/AddExtendedPickupProbeArea.md aliases.

BJDubb avatar Nov 20 '24 00:11 BJDubb

Thank you for the review @JayPaulinCodes

Waiting on some guidance about OBJECT/AddExtendedPickupProbeArea.md aliases.

Looks like some guidance was provided here: https://github.com/citizenfx/natives/pull/1221#discussion_r1849371981

And there is still a handful of my suggestions outstanding.

DevDaddyJacob avatar Nov 23 '24 18:11 DevDaddyJacob