citizenfx
fix(images): use github/repo as hosting
Images are now hosted with GitHub and pages use their relative URLs.
Not sure if this structure would be acceptable, but am open to suggestions.
While I see the big effort, I think just inserting images instead of imgur links wouldnt be the best. Maybe size vs format won't fit exactly. Some tweaks in the UI need maybe to be done. Have you try to build docs in local to see?
I also think that type of structure is fine since it's easy for anyone to change it. Maybe change the images name with a "standart" for people that will contribute in the future to follow. I would recommand maybe image description (short version). E.g. for SetCamSplineSmoothingStyle it would be graphic_details rather than Lj97T3F.
Anyways that's just my personnal opinion, good job :)
Have you try to build docs in local to see?
I have previewed every page in vscode's markdown preview extension. Thus why I made some adjustments to the formatting, so images actually display and use the next line for rendering.
Maybe change the images name with a "standart" for people that will contribute in the future to follow. I would recommand maybe image description (short version). E.g. for SetCamSplineSmoothingStyle it would be
graphic_detailsrather thanLj97T3F.
It would be fine to rename them at this point, since I already took the time to do all this. But I would like for this to be reviewed first, before doing further work.
Maybe @AvarianKnight could review?
I have previewed every page in vscode's markdown preview extension. Thus why I made some adjustments to the formatting, so images actually display and use the next line for rendering.
Vscode preview vs actual docs UI are not the same. You can build in localhost.
For the rest, before doing a big work like this it's always better to ask. Based on @4mmonium comment here (like you know), they are working in a solution wich not might be Github.
And for the code it-self, tweaks might need to be do for the correct format and size on every image.
Apologies for the time taken to correct this.
I have corrected the referenced files @AvarianKnight
Going to mark this as a draft for now, we're discussing on how this should be handled.
