natives icon indicating copy to clipboard operation
natives copied to clipboard

feat(natives/PED): Add naming and documentation for unnamed natives

Open theskiratta opened this issue 1 year ago • 2 comments

Using the amazing Alloc8or's native database, I added naming and some documentation for nearly all previously unnamed ped natives. The only one I skipped is 0x83a169eabcdb10a2 / SetPhonePaletteIDX, as I noticed this was already worked on as stated here.

I tried my best to do this as is explained in the guidelines and the examples given within those. I'm happy to fix any mistakes I may have made.

Example of change: 0x5407B7288D0478B7 was updated to it's proper name, COUNT_PEDS_IN_COMBAT_WITH_TARGET. I explained what the native does, what should be passed as a parameter and what should be expected as a return. Further, I linked to a similar native (COUNT_PEDS_IN_COMBAT_WITH_TARGET_WITHIN_RADIUS).

I tried to keep one commit per native to make changes and review easier.

theskiratta avatar Mar 20 '24 01:03 theskiratta

Thanks for the comment @PsychoShock ,

I wasn't aware of the 7-8 natives per PR, though I can understand why it would be wanted. I'm not an expert with GitHub, how would I go about making a PR that doesn't include all the commits I've made inside my fork, but only some, so that I can follow this guidance? Separate to that, please let me know what errors you noticed, specifically with the wrong params, so I may fix them?

Best Regards

theskiratta avatar Apr 21 '24 17:04 theskiratta

Hey, you could create a new branch of the fork for each PR, and use the cherry-pick command

Mathu-lmn avatar Apr 27 '24 16:04 Mathu-lmn

Thank you for the PR.

We're currently not accepting batch updates to natives.

AvarianKnight avatar Aug 06 '24 20:08 AvarianKnight