feat(interior): batch update interior natives

[ook3D]

[ook3D]

@4mmonium hey, would you be so kind as to take a look over these? im pretty confident i did everything correctly

[4mmonium]

@4mmonium hey, would you be so kind as to take a look over these? im pretty confident i did everything correctly

Hey there, I haven't ignored this, apologies for not giving you a reply earlier. There's quite a lot of changes done in this PR so I have been backlogging it for a bit. Will first need to check if everything is fine within the PR (such as cs_type declarations on parameters) and then merge locally to see if the build still compiles. There's often times where changing certain type declarations can break ABI compatibility, so we have to be careful.

Thank you for contributing and for letting me know! 😊

[ook3D]

@4mmonium hey, would you be so kind as to take a look over these? im pretty confident i did everything correctly

Hey there, I haven't ignored this, apologies for not giving you a reply earlier. There's quite a lot of changes done in this PR so I have been backlogging it for a bit. Will first need to check if everything is fine within the PR (such as cs_type declarations on parameters) and then merge locally to see if the build still compiles. There's often times where changing certain type declarations can break ABI compatibility, so we have to be careful.

Thank you for contributing and for letting me know! 😊

perfect, i totally understand, thanks!

[ook3D]

Hello,

This is a big PR. For nex time, try to limit every PR to 10 natives change so it can be reviewed / merged faster. I have review probably 15 but took almost 4h, but it's a big work so it's really appreciated by community (like me). I'll continue after this changes are made.

Thanks

alright sounds good, ill make smaller PRs in the future! 😄

[freedy69]

Maybe you could add to the entity set natives that you should call RefreshInterior after you apply changes to the interior for it to show up immediately? Would save some people from frustration im sure (:

[ook3D]

Hey,

Can you add in the format like this:

**Note:** Add the text there.

For the RefreshInterior.

Thanks.

of course, will fix this

[ook3D]

any update on this? 😄

[PsychoShock]

For a better chance to be commit, you should separate them to 7-8 natives per PR. The issue right now is, if something is broken and need to be revert, it's a lot of natives that will be affected too. It's also easier to review them. Just saying that on personnal experience.

[ook3D]

For a better chance to be PR, you should separate them to 7-8 natives per PR. The issue right now is, if something is broken and need to be revert, it's a lot of natives that will be affected too. It's also easier to review them. Just saying that on personnal experience.

fair enough

[AvarianKnight]

Thank you for the PR.

We're currently not accepting batch updates to natives.