citizenfx
tweak(server-impl): Increase asset warning sizes
Goal of this PR
Cleanup unnecessary warnings in server console
How is this PR achieving the goal
upping the sizes for each warning level
This PR applies to the following area(s)
FiveM, Server
Successfully tested on
Game builds: .. 3258 Platforms: Windows, Linux Windows
Checklist
- [x] Code compiles and has been tested successfully.
- [x] Code explains itself well and/or is documented.
- [x] My commit message explains what the changes do and what they are for.
- [x] No extra compilation warnings are added by these changes.
Fixes issues
this will lead to even more problems. everyone is experiencing texture loss rn, low FPS, this will only help modders deliver bad assets. my view over this was that an asset that isn't optimized properly shouldn't even start.
i saw you are in hane mods, he delivers assets with warnings of 100 + mb. my entire server lost textures after my team added a mlo from him.
i get your idea tho, but for example a 30mb yft / ydd is too heavy. it wouldn't even gen warned about.
i agree tho with some ytds going a little bit over 16mb
that's only my opinion!
so what i'm saying the best warning is more filtered, ytd's should have a warning, yft's another warnings, ydd another warnings, ydr's another warnings.
this will lead to even more problems. everyone is experiencing texture loss rn, low FPS, this will only help modders deliver bad assets. my view over this was that an asset that isn't optimized properly shouldn't even start.
i saw you are in hane mods, he delivers assets with warnings of 100 + mb. my entire server lost textures after my team added a mlo from him.
i get your idea tho, but for example a 30mb yft / ydd is too heavy. it wouldn't even gen warned about.
i agree tho with some ytds going a little bit over 16mb
that's only my opinion!
so what i'm saying the best warning is more filtered, ytd's should have a warning, yft's another warnings, ydd another warnings, ydr's another warnings.
You do realize there is vanilla assets that say these warnings currently right? Did you miss that part? How is it unoptimized if it's literally from rockstar themselves? You're missing the point of the PR.
As i've said, 16+mb yft/ydr/ydd is too much. You're only showing ytd's. The warning size is general. Those warnings were based on nta's research on texture loss.
As i've said, 16+mb yft/ydr/ydd is too much. You're only showing ytd's. The warning size is general. Those warnings were based on nta's research on texture loss.
please link this research, the current "texture loss" issues is not caused by this.
The console was made to report warnings, errors, and debug information — it’s not meant to look pretty. It’s built to be functional, and trying to cover that up does more harm than good. It’s basically like drying ice — in the end, it literally changes nothing.
The console was made to report warnings, errors, and debug information — it’s not meant to look pretty. It’s built to be functional, and trying to cover that up does more harm than good. It’s basically like drying ice — in the end, it literally changes nothing.
yet again, you are not understanding the point of this PR. why would there be warnings for assets rockstar has made? are these assets poorly made?
With these proposed changes would Rockstar assets not still get the warning? The values still seem a bit low. Maybe also make the increments consistent like the original implementation too.
With these proposed changes would Rockstar assets not still get the warning? The values still seem a bit low. Maybe also make the increments consistent like the original implementation too.
The goal is to have less assets show as warnings, and mainly the warning saying it will lead to issues, it's okay that it prints the size still
With these proposed changes would Rockstar assets not still get the warning? The values still seem a bit low. Maybe also make the increments consistent like the original implementation too.
The goal is to have less assets show as warnings, and mainly the warning saying it will lead to issues, it's okay that it prints the size still
It leads to issues.
With these proposed changes would Rockstar assets not still get the warning? The values still seem a bit low. Maybe also make the increments consistent like the original implementation too.
The goal is to have less assets show as warnings, and mainly the warning saying it will lead to issues, it's okay that it prints the size still
It leads to issues.
So are you going to prove that? You still have not linked this research you've mentioned, and like I said, the current "texture loss" issues are not related to assets with high memory usage.
You can literally restream an unmodified rockstar asset and get an warning, how is that going to lead to issues, it's a flaw in the system