fivem icon indicating copy to clipboard operation
fivem copied to clipboard

tweak(codegen): set VAR_STRING as an unsupported type for OAL

Open AvarianKnight opened this issue 1 year ago • 3 comments

Goal of this PR

Allow VAR_STRING to be used on RDR when using OAL

How is this PR achieving the goal

Marks it as 'unsupported' so it wont be generated as a supported native for OAL

This PR applies to the following area(s)

RedM

Successfully tested on

This was only tested that it doesn't add to the map in NativesRDR.h

Game builds: ..

Platforms: Windows, Linux

Checklist

  • [ ] Code compiles and has been tested successfully.
  • [x] Code explains itself well and/or is documented.
  • [x] My commit message explains what the changes do and what they are for.
  • [x] No extra compilation warnings are added by these changes.

Fixes issues

Fixes the issue @outsider31000 reported

AvarianKnight avatar Oct 08 '24 23:10 AvarianKnight

didnt know that list existed. thanks for this ~does this mean VarString will still work right? just wont be considered by the OAL?~

outsider31000 avatar Oct 08 '24 23:10 outsider31000

didnt know that list existed. does this mean VarString will still work right? just wont be considered by the OAL?

Yes, it'll fallback to the normal NativeInvoke.

AvarianKnight avatar Oct 08 '24 23:10 AvarianKnight

yes thanks, I read the description wrong.

outsider31000 avatar Oct 08 '24 23:10 outsider31000

someone merge this please.

outsider31000 avatar Nov 22 '24 19:11 outsider31000