fivem icon indicating copy to clipboard operation
fivem copied to clipboard

fix(onesync): CPlayerGameStateDataNode for b3095

Open Korioz opened this issue 1 year ago • 3 comments

Goal of this PR

Fix some server-side natives that return invalid values on game build >= 3095 like: GET_PLAYER_INVINCIBLE GET_PLAYER_WEAPON_DAMAGE_MODIFIER GET_PLAYER_MELEE_WEAPON_DAMAGE_MODIFIER

How is this PR achieving the goal

Adding a missing bit reading operation on CPlayerGameStateDataNode for >= b3095

This PR applies to the following area(s)

Server

Successfully tested on

Game builds: 2944, 3095, 3258

Platforms: Windows

Checklist

  • [x] Code compiles and has been tested successfully.
  • [x] Code explains itself well and/or is documented.
  • [x] My commit message explains what the changes do and what they are for.
  • [x] No extra compilation warnings are added by these changes.

Fixes issues

Fixes #2748

Korioz avatar Aug 25 '24 15:08 Korioz

Are you sure it's the only one in 3095? After unk101, I see two int (8 bytes each)

spacevx avatar Aug 25 '24 15:08 spacevx

image Maybe it's on 3258 and not 3095

spacevx avatar Aug 25 '24 15:08 spacevx

image Maybe it's on 3258 and not 3095

Good catch

Korioz avatar Aug 25 '24 16:08 Korioz

Thanks for your contribution.

prikolium-cfx avatar Sep 17 '24 08:09 prikolium-cfx