fivem icon indicating copy to clipboard operation
fivem copied to clipboard

tweak(decrapped/native): remove files not supported

Open PsychoShock opened this issue 1 year ago • 5 comments

Goal of this PR

Following natives that are not supported anymore, this PR will remove from the docs.

How is this PR achieving the goal

Remove natives not supported anymore.

This PR applies to the following area(s)

Natives

Successfully tested on

Checklist

  • [x] Code compiles and has been tested successfully.
  • [x] Code explains itself well and/or is documented.
  • [x] My commit message explains what the changes do and what they are for.
  • [x] No extra compilation warnings are added by these changes.

Fixes issues

Everything is already closed.

PsychoShock avatar Aug 19 '24 16:08 PsychoShock

Isn't removing SET_SNAKEOIL_FOR_ENTRY a breaking change since it's currently implemented in adhesive?

TheIndra55 avatar Aug 19 '24 23:08 TheIndra55

Isn't removing SET_SNAKEOIL_FOR_ENTRY a breaking change since it's currently implemented in adhesive?

It might be yeah, removed the ready-to-merge label for now, so that others can re-evaluate. (Given i have no idea how the code gen system works)

The SET_SNAKEOIL_FOR_ENTRY native is currently implemented in fivem-private, it shouldn't be used anymore, but i'd expect removing it to break some resources on a rare occasion. Ideally this native would be deprecated in a more 'friendly' way in the future.

neptunium-cfx avatar Aug 19 '24 23:08 neptunium-cfx

I'll speak in intern and comeback to a solution here when I'll have one for that specific native. Others should be fine.

PsychoShock avatar Aug 19 '24 23:08 PsychoShock

After talking, I think this is the "best" current way to implement the files removed. For hiding the rest used by adhesive, I will work on a different PR.

PsychoShock avatar Sep 26 '24 04:09 PsychoShock

Thanks for your contribution, but we don't remove declarations to not break compatibility with existing scripts. You can leave only your warning message changes and then we can accept it.

prikolium-cfx avatar Oct 04 '24 12:10 prikolium-cfx

@PsychoShock Bumping in case you want to follow prikolium's advice (or close the PR)

Mathu-lmn avatar Mar 03 '25 15:03 Mathu-lmn