fivem icon indicating copy to clipboard operation
fivem copied to clipboard

tweak(clrcore/external): update enums

Open BerkieBb opened this issue 2 years ago • 6 comments

These haven't been updated in a while, so they deserve one

BerkieBb avatar Nov 27 '22 17:11 BerkieBb

Quick question, would you want me to make a new commit for all the changes I'm going to do or would you want me to amend my commit?

BerkieBb avatar Dec 22 '22 15:12 BerkieBb

You can just continue on here, when you're ready just request a review oslt :) In the end we do request to squash them.

thorium-cfx avatar Dec 22 '22 16:12 thorium-cfx

Aside from the weird changes in World.cs and the conflicting enums for game builds like RadioStation.cs, all requested changes have been applied.

BerkieBb avatar Jan 08 '23 16:01 BerkieBb

I should also update everything to 2802 probably

BerkieBb avatar Jan 08 '23 16:01 BerkieBb

IIRC these enums can differ per build, may we want to continue with this then we first need to confirm and think of ways to address that.

thorium-cfx avatar Nov 03 '23 14:11 thorium-cfx

IIRC these enums can differ per build, may we want to continue with this then we first need to confirm and think of ways to address that.

Yeah I do need to update everything again to accomodate for all the new builds again, so I'll look over it

BerkieBb avatar Nov 03 '23 17:11 BerkieBb