styles icon indicating copy to clipboard operation
styles copied to clipboard

Create revue-suisse-dhistoire.csl

Open POBrien333 opened this issue 1 year ago • 11 comments

Closes https://github.com/citation-style-language/styles/issues/7184#issuecomment-2324746726

POBrien333 avatar Sep 02 '24 14:09 POBrien333

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/revue-suisse-dhistoire.csl (rendering failure)
dependent/rivista-storica-svizzera.csl (rendering failure)

github-actions[bot] avatar Sep 02 '24 14:09 github-actions[bot]

No, please put the ISSN back in as per my comment on the issue

adam3smith avatar Sep 02 '24 15:09 adam3smith

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 19:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 19:09 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff:
@@ -1 +1,2 @@
+"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report for details.

github-actions[bot] avatar Sep 02 '24 19:09 github-actions[bot]

Might be that the CI doesn't look at the updated ISSN list. I'll double check and merge, don't worry about the failure

Sent from my phone

On Mon, Sep 2, 2024, 15:54 github-actions[bot] @.***> wrote:

😟 There are some issues with your submission. 1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {} got: {"0036-7834"=>["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"]}

(compared using ==)

Diff: @@ -1 +1,2 @@ +"0036-7834" => ["revue-suisse-dhistoire", "rivista-storica-svizzera", "schweizerische-zeitschrift-fur-geschichte"],

Please check the test report https://github.com/citation-style-language/styles/actions/runs/10672391101 for details.

— Reply to this email directly, view it on GitHub https://github.com/citation-style-language/styles/pull/7186#issuecomment-2325250702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7PWSSLKMLOLMKZD2BG4DZUS7AJAVCNFSM6AAAAABNQNTZHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGI2TANZQGI . You are receiving this because you commented.Message ID: @.***>

adam3smith avatar Sep 02 '24 19:09 adam3smith

Hi Sebastian, Would you be able to merge this in the coming days? Then I can get this off my todo list and also inform this former client it's now up. Much appreciate your efforts! 🙏🏽

POBrien333 avatar Sep 10 '24 08:09 POBrien333

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

dependent/revue-suisse-dhistoire.csl (rendering failure)
dependent/rivista-storica-svizzera.csl (rendering failure)

github-actions[bot] avatar Sep 11 '24 14:09 github-actions[bot]

Merged it!

bwiernik avatar Sep 11 '24 14:09 bwiernik

Excellent!! Thank you so much both for helping with this. :)

POBrien333 avatar Sep 12 '24 08:09 POBrien333