styles icon indicating copy to clipboard operation
styles copied to clipboard

Update ieee.csl to include video directors

Open POBrien333 opened this issue 1 year ago • 4 comments

https://forums.zotero.org/discussion/113145/ieee-online-video-e-g-youtube#latest

I feel like we should include some other names as well. Any suggestions which?

POBrien333 avatar Mar 27 '24 11:03 POBrien333

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

github-actions[bot] avatar Mar 27 '24 11:03 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

ieee: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[48, "48:0: ERROR: Type dateTime doesn't allow value '2024-03-2719:39:58+00:00'"], [48, "48:0: ERROR...ERROR: Invalid sequence in interleave"], [3, "3:0: ERROR: Element info failed to validate content"]].empty?` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Mar 27 '24 11:03 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

github-actions[bot] avatar Mar 27 '24 11:03 github-actions[bot]

I've collected all the sample entries of the IEEE manual into Zotero format (via https://anystyle.io/) and they may help testing CSL styles: https://gist.github.com/zepinglee/f35d04cbbc240ad0de21de79818761cf.

zepinglee avatar May 09 '24 14:05 zepinglee

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

github-actions[bot] avatar Jul 12 '24 14:07 github-actions[bot]

@POBrien333 Should we go ahead and merge this now and can add more in a future PR?

bwiernik avatar Jul 15 '24 00:07 bwiernik

Yeah, I'd say so. Let's get that out to the users. :)

POBrien333 avatar Jul 15 '24 08:07 POBrien333

:worried: There are some issues with your submission.

1 test failed

ieee: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[51, "51:0: ERROR: Did not expect element locale there"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Jul 15 '24 09:07 github-actions[bot]

Is the type "preprint" not a valid item type (yet)?

POBrien333 avatar Jul 15 '24 09:07 POBrien333

Preprint is type "article"

bwiernik avatar Jul 15 '24 11:07 bwiernik

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

github-actions[bot] avatar Jul 15 '24 13:07 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

ieee.csl (modified style; unchanged output for sample items)
[1], [2]
[3], [4]

[1]B. Hancké, M. Rhodes, and M. Thatcher, Eds., Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007.
[2]“CSL search by example,” Citation Style Editor. Accessed: Dec. 15, 2012. [Online]. Available: http://editor.citationstyles.org/searchByExample/
[3]I. Mares, “Firms and the welfare state: When, why, and how does social policy matter to employers?,” in Varieties of capitalism. The institutional foundations of comparative advantage, P. A. Hall and D. Soskice, Eds., New York: Oxford University Press, 2001, pp. 184–213.
[4]M. Fenner et al., “A data citation roadmap for scholarly data repositories,” Sci. Data, vol. 6, no. 1, p. 28, Apr. 2019, doi: 10.1038/s41597-019-0031-8.

github-actions[bot] avatar Jul 15 '24 13:07 github-actions[bot]