styles icon indicating copy to clipboard operation
styles copied to clipboard

Create modern-language-association-annotated-bibliography.csl

Open calumapplepie opened this issue 1 year ago • 14 comments

Note: this style currently fails to render with hanging indents for an unknown reason. I tested with Libreoffice, for the record

calumapplepie avatar Sep 28 '23 23:09 calumapplepie

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

github-actions[bot] avatar Sep 28 '23 23:09 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association-annotated-bibliography.csl (new)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/
.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8
.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007
.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213
.

github-actions[bot] avatar Sep 29 '23 00:09 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association-annotated-bibliography.csl (new)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/
.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8
.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007
.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213
.

github-actions[bot] avatar Sep 29 '23 02:09 github-actions[bot]

I haven't tested, but I thought the display elements don't work well with formatting added through cs:bibliography (like hanging-indent="true") here?

I'll generally say that I'm still quite skeptical about including annotated bibliographies beyond the two we already have. It's a rabbit hole of possible additions that all vary in three lines of code & require maintenance.

adam3smith avatar Sep 29 '23 02:09 adam3smith

Thanks! I made a comment for how to fix the indenting

The indentation problem isn't that the note has a first-line indent: that was an intentional choice on my part, to set the note apart from the citation. The problem is that the citation lacks a hanging indent as a result of the display problems

calumapplepie avatar Sep 29 '23 16:09 calumapplepie

I haven't tested, but I thought the display elements don't work well with formatting added through cs:bibliography (like hanging-indent="true") here?

It doesn't, no, and I mention the limitation in my style description

I'll generally say that I'm still quite skeptical about including annotated bibliographies beyond the two we already have. It's a rabbit hole of possible additions that all vary in three lines of code & require maintenance.

That's true, but MLA is probably one of the most used styles in education, which is where a lot of people are tasked with creating annotated bibliographies in a PDF form. I personally have been asked to make such a document thrice in three different courses, always in MLA format.

While the combinationatorial explosion is problematic, I don't think most styles will want, need, or get this additional form. It's really only in an educational setting where you need to produce annotated bibliographies as standalone documents, as opposed to just reading the "notes" section in Zorero.

calumapplepie avatar Sep 29 '23 16:09 calumapplepie

I think MLA is a reasonable one to add. It's probably the most common format requested of students after APA (eg many US high school students).

bwiernik avatar Sep 30 '23 02:09 bwiernik

I intentionally used display=indent, as opposed to the display=block added by @bwiernik . The indent added isn't the problem I mention and face. I want the note block to be indented; the problem is making it display as a block at all causes the citation to lose its hanging indent.

With display=indent: image

With display=block: image

Without either: image

The ideal layout would probably be: image

But I see no way to accomplish that.

calumapplepie avatar Oct 01 '23 19:10 calumapplepie

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association-annotated-bibliography.csl (new)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/
.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8
.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007
.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213
.

github-actions[bot] avatar Oct 01 '23 19:10 github-actions[bot]

What program are you using to generate your bibliographies?

As @adam3smith mentions, the display behavior depends somewhat on the environment in which the citation is rendered. I don't see the behavior you describe with Zotero.

With display="block" using Zotero's Word plugin or RTF export (hanging indent with annotation aligned with hanging): image

With display="block" using Zotero's direct HTML export (hanging indent with annotation aligned with margin, with its own hanging indent): (Picture didn't paste correctly, will redo later)

With display="indent" and html output, I see a hanging indent and then further indenting of the annotation: image

With display="indent" and the Word plugin or RTF output, I see no hanging indent and the annotation indented: image

bwiernik avatar Oct 01 '23 20:10 bwiernik

Based on this behavior and precedent with the existing annotated bibliography styles, display="block" is what should be used.

bwiernik avatar Oct 01 '23 20:10 bwiernik

Appolgies, this fell off my to-do list. I used Libreoffice; if the problematic behavior can't be reproduced in other programs, I'll use display=block.

Maybe someone should look into making hanging-indent behavior more consistent, possibly by making it less of a special-case.

calumapplepie avatar Nov 04 '23 20:11 calumapplepie

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

modern-language-association-annotated-bibliography.csl (new)
(Hancké et al.; “CSL Search by Example”)
(Mares; Fenner et al.)

“CSL Search by Example.” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/
.
Fenner, Martin, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data, vol. 6, no. 1, Apr. 2019, p. 28. Nature, https://doi.org/10.1038/s41597-019-0031-8
.
Hancké, Bob, et al., editors. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford University Press, 2007
.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, Oxford University Press, 2001, pp. 184–213
.

github-actions[bot] avatar Nov 04 '23 20:11 github-actions[bot]

I believe this is in the state that @bwiernik desired, after the above force-push; if not, I am comfortable with the changes requested, now that I know it's a libreoffice-specific issue. Thank you!

calumapplepie avatar Dec 16 '23 04:12 calumapplepie