styles icon indicating copy to clipboard operation
styles copied to clipboard

Bug fixes triangle.csl

Open POBrien333 opened this issue 2 years ago • 3 comments

via https://forums.zotero.org/discussion/comment/418240/#Comment_418240

POBrien333 avatar Sep 29 '22 11:09 POBrien333

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

github-actions[bot] avatar Sep 29 '22 11:09 github-actions[bot]

:worried: There are some issues with your submission.

2 tests failed

triangle: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[0, "534:1: FATAL: Premature end of data in tag style line 2"]].empty?` to be truthy, got false

triangle: must define all macros that are called by <text/> and <key/> elements

expected `{"author"=>#<CSL::Style::Macro name="author" children=[1]>, "author-bib"=>#<CSL::Style::Macro name="a...earpage-bib" children=[9]>, "yearpage-ndbp"=>#<CSL::Style::Macro name="yearpage-ndbp" children=[1]>}.has_key?("volume")` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Sep 29 '22 11:09 github-actions[bot]

:worried: There are some issues with your submission.

2 tests failed

triangle: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[0, "534:1: FATAL: Premature end of data in tag style line 2"]].empty?` to be truthy, got false

triangle: must define all macros that are called by <text/> and <key/> elements

expected `{"author"=>#<CSL::Style::Macro name="author" children=[1]>, "author-bib"=>#<CSL::Style::Macro name="a...earpage-bib" children=[9]>, "yearpage-ndbp"=>#<CSL::Style::Macro name="yearpage-ndbp" children=[1]>}.has_key?("volume")` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Sep 30 '22 08:09 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

triangle.csl (modified style)
Bob Hancké, Martin Rhodes et Mark Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007 « CSL search by example », Citation Style Editor, 2012.
Isabela Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », in Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213 Martin Fenner, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, Maryann Martone et Tim Clark, « A data citation roadmap for scholarly data repositories », Scientific Data, 10 avril 2019, vol. 6, nᵒ 1, p. 28, doi:10.1038/s41597-019-0031-8.

« CSL search by example », Citation Style Editor, 2012, consulté le 15 décembre 2012, URL :  http://editor.citationstyles.org/searchByExample/.
Fenner Martin, Crosas Mercè, Grethe Jeffrey S., Kennedy David, Hermjakob Henning, Rocca-Serra Phillippe, Durand Gustavo, Berjon Robin, Karcher Sebastian, Martone Maryann et Clark Tim, « A data citation roadmap for scholarly data repositories », Scientific Data, 10 avril 2019, vol. 6, nᵒ 1, p. 28, doi:10.1038/s41597-019-0031-8.
Hancké Bob, Rhodes Martin et Thatcher Mark (dir.), Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York, Oxford University Press, 2007.
Mares Isabela, « Firms and the welfare state: When, why, and how does social policy matter to employers? », in Peter A. Hall et David Soskice (dir.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, Oxford University Press, 2001, p. 184‑213.
-<span style="font-style: normal"><span style="font-style: normal">Bob <span style="font-variant: small-caps">Hancké</span></span>, <span style="font-style: normal">Martin <span style="font-variant: small-caps">Rhodes</span></span> et <span style="font-style: normal">Mark <span style="font-variant: small-caps">Thatcher</span></span></span> (dir.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press, <span style="font-style: normal">2007</span> « <span style="font-style: normal">CSL search by example</span> », <i>Citation Style Editor</i>, <span style="font-style: normal">2012</span>.<br/>
-<span style="font-style: normal"><span style="font-style: normal">Isabela <span style="font-variant: small-caps">Mares</span></span></span>, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <i>in</i> <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> et <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (dir.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press, <span style="font-style: normal">2001, <span style="font-style: normal">p. 184‑213</span></span> <span style="font-style: normal"><span style="font-style: normal">Martin <span style="font-variant: small-caps">Fenner</span></span>, <span style="font-style: normal">Mercè <span style="font-variant: small-caps">Crosas</span></span>, <span style="font-style: normal">Jeffrey S. <span style="font-variant: small-caps">Grethe</span></span>, <span style="font-style: normal">David <span style="font-variant: small-caps">Kennedy</span></span>, <span style="font-style: normal">Henning <span style="font-variant: small-caps">Hermjakob</span></span>, <span style="font-style: normal">Phillippe <span style="font-variant: small-caps">Rocca-Serra</span></span>, <span style="font-style: normal">Gustavo <span style="font-variant: small-caps">Durand</span></span>, <span style="font-style: normal">Robin <span style="font-variant: small-caps">Berjon</span></span>, <span style="font-style: normal">Sebastian <span style="font-variant: small-caps">Karcher</span></span>, <span style="font-style: normal">Maryann <span style="font-variant: small-caps">Martone</span></span> et <span style="font-style: normal">Tim <span style="font-variant: small-caps">Clark</span></span></span>, « <span style="font-style: normal">A data citation roadmap for scholarly data repositories</span> », <i>Scientific Data</i>, <span style="font-style: normal">10 avril 2019, vol. 6</span>, nᵒ 1, <span style="font-style: normal">p. 28</span>, doi:10.1038/s41597-019-0031-8.<br/>
+Bob <span style="font-variant: small-caps">Hancké</span>, Martin <span style="font-variant: small-caps">Rhodes</span> et Mark <span style="font-variant: small-caps">Thatcher</span> (dir.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press, 2007 « CSL search by example », <i>Citation Style Editor</i>, 2012.<br/>
+Isabela <span style="font-variant: small-caps">Mares</span>, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <i>in</i> Peter A. <span style="font-variant: small-caps">Hall</span> et David <span style="font-variant: small-caps">Soskice</span> (dir.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press, 2001, p. 184‑213 Martin <span style="font-variant: small-caps">Fenner</span>, Mercè <span style="font-variant: small-caps">Crosas</span>, Jeffrey S. <span style="font-variant: small-caps">Grethe</span>, David <span style="font-variant: small-caps">Kennedy</span>, Henning <span style="font-variant: small-caps">Hermjakob</span>, Phillippe <span style="font-variant: small-caps">Rocca-Serra</span>, Gustavo <span style="font-variant: small-caps">Durand</span>, Robin <span style="font-variant: small-caps">Berjon</span>, Sebastian <span style="font-variant: small-caps">Karcher</span>, Maryann <span style="font-variant: small-caps">Martone</span> et Tim <span style="font-variant: small-caps">Clark</span>, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>, 10 avril 2019, vol. 6, nᵒ 1, p. 28, doi:10.1038/s41597-019-0031-8.<br/>
 <hr/>
-« <span style="font-style: normal">CSL search by example</span> », <i>Citation Style Editor</i>, <span style="font-style: normal">2012</span>, consulté le 15 décembre 2012, URL :  http://editor.citationstyles.org/searchByExample/.<br/>
-<span style="font-style: normal"><span style="font-style: normal"><span style="font-variant: small-caps">Fenner</span> Martin</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Crosas</span> Mercè</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Grethe</span> Jeffrey S.</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Kennedy</span> David</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Hermjakob</span> Henning</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Rocca-Serra</span> Phillippe</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Durand</span> Gustavo</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Berjon</span> Robin</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Karcher</span> Sebastian</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Martone</span> Maryann</span> et <span style="font-style: normal"><span style="font-variant: small-caps">Clark</span> Tim</span></span>, « <span style="font-style: normal">A data citation roadmap for scholarly data repositories</span> », <i>Scientific Data</i>, <span style="font-style: normal">10 avril 2019, vol. 6</span>, nᵒ 1, <span style="font-style: normal">p. 28</span>, doi:10.1038/s41597-019-0031-8.<br/>
-<span style="font-style: normal"><span style="font-style: normal"><span style="font-variant: small-caps">Hancké</span> Bob</span>, <span style="font-style: normal"><span style="font-variant: small-caps">Rhodes</span> Martin</span> et <span style="font-style: normal"><span style="font-variant: small-caps">Thatcher</span> Mark</span></span> (dir.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press, <span style="font-style: normal">2007</span>.<br/>
-<span style="font-style: normal"><span style="font-style: normal"><span style="font-variant: small-caps">Mares</span> Isabela</span></span>, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <i>in</i> <span style="font-style: normal"><span style="font-style: normal">Peter A. <span style="font-variant: small-caps">Hall</span></span> et <span style="font-style: normal">David <span style="font-variant: small-caps">Soskice</span></span></span> (dir.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press, <span style="font-style: normal">2001, p. 184‑213</span>.<br/>
+« CSL search by example », <i>Citation Style Editor</i>, 2012, consulté le 15 décembre 2012, URL :  http://editor.citationstyles.org/searchByExample/.<br/>
+<span style="font-variant: small-caps">Fenner</span> Martin, <span style="font-variant: small-caps">Crosas</span> Mercè, <span style="font-variant: small-caps">Grethe</span> Jeffrey S., <span style="font-variant: small-caps">Kennedy</span> David, <span style="font-variant: small-caps">Hermjakob</span> Henning, <span style="font-variant: small-caps">Rocca-Serra</span> Phillippe, <span style="font-variant: small-caps">Durand</span> Gustavo, <span style="font-variant: small-caps">Berjon</span> Robin, <span style="font-variant: small-caps">Karcher</span> Sebastian, <span style="font-variant: small-caps">Martone</span> Maryann et <span style="font-variant: small-caps">Clark</span> Tim, « A data citation roadmap for scholarly data repositories », <i>Scientific Data</i>, 10 avril 2019, vol. 6, nᵒ 1, p. 28, doi:10.1038/s41597-019-0031-8.<br/>
+<span style="font-variant: small-caps">Hancké</span> Bob, <span style="font-variant: small-caps">Rhodes</span> Martin et <span style="font-variant: small-caps">Thatcher</span> Mark (dir.), <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York, Oxford University Press, 2007.<br/>
+<span style="font-variant: small-caps">Mares</span> Isabela, « Firms and the welfare state: When, why, and how does social policy matter to employers? », <i>in</i> Peter A. <span style="font-variant: small-caps">Hall</span> et David <span style="font-variant: small-caps">Soskice</span> (dir.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i>, New York, Oxford University Press, 2001, p. 184‑213.<br/>

github-actions[bot] avatar Nov 23 '22 04:11 github-actions[bot]

Thanks!

adam3smith avatar Nov 28 '22 04:11 adam3smith