styles icon indicating copy to clipboard operation
styles copied to clipboard

Update american-institute-of-physics.csl

Open JorgeG94 opened this issue 2 years ago • 5 comments

I am about to submit a paper to Molecular Physics and when looking at the reference guidelines I noted that it uses American Institute of Physics which Zotero has. However, based on the document provided by them. The link here downloads a PDF, you can navigate to the site here and do it yourself.

The citation style needs citations to look like this -> [1] and [1-14] while the one in the Zotero style repository it uses superscripts. This PR aims to fix this and update it to what Mol. Phys. requires.

JorgeG94 avatar May 24 '22 19:05 JorgeG94

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

github-actions[bot] avatar May 24 '22 19:05 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

american-institute-of-physics.csl (modified style)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
-<span style="vertical-align: super">1,2</span><br/>
-<span style="vertical-align: super">3,4</span><br/>
+[1],[2]<br/>
+[3],[4]<br/>
 <hr/>
-<span style="vertical-align: super">1</span> B. Hancké, M. Rhodes, and M. Thatcher, editors , <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford University Press, Oxford and New York, 2007).<br/>
-<span style="vertical-align: super">2</span>Citation Style Editor (2012).<br/>
-<span style="vertical-align: super">3</span> I. Mares, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.<br/>
-<span style="vertical-align: super">4</span> M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data <b>6</b>, 28 (2019).<br/>
+[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford University Press, Oxford and New York, 2007).<br/>
+[2]Citation Style Editor (2012).<br/>
+[3] I. Mares, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.<br/>
+[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data <b>6</b>, 28 (2019).<br/>

github-actions[bot] avatar May 24 '22 19:05 github-actions[bot]

Thanks -- while this is right for the T&F AIP style, the actual AIP publication manual, which the AIP style follows, does prescribe superscript numbers, so the style is OK. We'd take a new style for the T&F version with metadata along these lines

<title>Taylor &amp; Francis - American Institute of Physics</title>
<id>http://www.zotero.org/styles/taylor-and-francis-aip</id>
```   

adam3smith avatar May 31 '22 01:05 adam3smith

Oh this makes entire sense, so I should basically redraft this as a new style? right?

JorgeG94 avatar May 31 '22 02:05 JorgeG94

Oh this makes entire sense, so I should basically redraft this as a new style? right?

Correct, yes -- you can do that in the same PR if you know how to or start a new one if that's easier. Thanks!

adam3smith avatar May 31 '22 15:05 adam3smith

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

american-institute-of-physics.csl (modified style)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
-<span style="vertical-align: super">1,2</span><br/>
-<span style="vertical-align: super">3,4</span><br/>
+[1],[2]<br/>
+[3],[4]<br/>
 <hr/>
-<span style="vertical-align: super">1</span> B. Hancké, M. Rhodes, and M. Thatcher, editors , <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford University Press, Oxford and New York, 2007).<br/>
-<span style="vertical-align: super">2</span>Citation Style Editor (2012).<br/>
-<span style="vertical-align: super">3</span> I. Mares, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.<br/>
-<span style="vertical-align: super">4</span> M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data <b>6</b>, 28 (2019).<br/>
+[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , <i>Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy</i> (Oxford University Press, Oxford and New York, 2007).<br/>
+[2]Citation Style Editor (2012).<br/>
+[3] I. Mares, in <i>Varieties of Capitalism. The Institutional Foundations of Comparative Advantage</i>, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.<br/>
+[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data <b>6</b>, 28 (2019).<br/>

taylor-and-francis-aip.csl (new)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
dependent/molecular-physics.csl (rendering failure)

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

american-institute-of-physics: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[22, "22:0: ERROR: Did not expect element macro there"], [22, "22:0: ERROR: Element style has extra content: macro"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

taylor-and-francis-aip.csl (new)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
dependent/molecular-physics.csl (rendering failure)

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]

:worried: There are some issues with your submission.

1 test failed

american-institute-of-physics: must validate against the CSL 1.0.1 schema Please check your style at http://validator.citationstyles.org/

expected `[[0, "90:14: FATAL: Opening and ending tag mismatch: sort line 85 and layout"]].empty?` to be truthy, got false

Please check the test report for details.

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

taylor-and-francis-aip.csl (new)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
dependent/molecular-physics.csl (rendering failure)

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]

:smiley: Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

taylor-and-francis-aip.csl (new)
[1],[2]
[3],[4]

[1] B. Hancké, M. Rhodes, and M. Thatcher, editors , Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford University Press, Oxford and New York, 2007).
[2]Citation Style Editor (2012).
[3] I. Mares, in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by P.A. Hall and D. Soskice (Oxford University Press, New York, 2001), pp. 184–213.
[4] M. Fenner, M. Crosas, J.S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, and T. Clark, Sci. Data 6, 28 (2019).
dependent/molecular-physics.csl (rendering failure)

github-actions[bot] avatar Mar 12 '23 03:03 github-actions[bot]