superforms-web icon indicating copy to clipboard operation
superforms-web copied to clipboard

Some Get Started codeblocks don't change with different validators.

Open SebasF1349 opened this issue 1 year ago • 2 comments

There are two codeblocks in the Get Started page that don't change for each validator and are always shown with zod:

https://github.com/ciscoheat/superforms-web/blob/main/src/routes/get-started/%5B...lib%5D/%2Bpage.md?plain=1#L303

https://github.com/ciscoheat/superforms-web/blob/main/src/routes/get-started/%5B...lib%5D/%2Bpage.md?plain=1#L391

I can make a pr to fix them if you like.

SebasF1349 avatar Mar 16 '24 17:03 SebasF1349

I'm trying to think of a better, more "templatized" way to display the code for all the different variations, let me try that first. :)

ciscoheat avatar Mar 17 '24 08:03 ciscoheat

There are two codeblocks in the Get Started page that don't change for each validator and are always shown with zod:

https://github.com/ciscoheat/superforms-web/blob/main/src/routes/get-started/%5B...lib%5D/%2Bpage.md?plain=1#L303

https://github.com/ciscoheat/superforms-web/blob/main/src/routes/get-started/%5B...lib%5D/%2Bpage.md?plain=1#L391

I can make a pr to fix them if you like.

I think they do change now, so maybe this should be closed after you check em

7heMech avatar Nov 02 '24 08:11 7heMech