thor

thor copied to clipboard

This adds Daala's low pass extension, and codes the cropped size in the bitstream.

tdaede

Replace Makefile with autoconf for builds/detection/dist release

8

The vc projects have to be checked as they might be broken.

fcartegnie

Add Daala's Entropy Coder to Thor

3

tterribe

Using %d for unsigned intergers, instead of %u

1

Tedious, could submit a patch to save you time? :) **common/simd/v64_intrinsics_c.h:794 common/simd/v64_intrinsics_c.h:806 common/simd/v64_intrinsics_c.h:818 common/simd/v64_intrinsics_c.h:830 common/simd/v64_intrinsics_c.h:842 common/simd/v64_intrinsics_c.h:854 common/simd/v64_intrinsics_c.h:865 common/simd/v64_intrinsics_c.h:876 common/simd/v64_intrinsics_c.h:887 common/simd/v64_intrinsics_c.h:909 common/simd/v128_intrinsics_c.h:590**

davidsilveiro

Addition of a build system generator

2

I suggest to reuse a higher level build system than [your current small make file](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/Makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)

elfring

Several of the while(!done) loops will loop forever if fed a constant stream of zeros. Once they read all of the bits in the file, this is exactly what they...

tterribe

reserved identifier violation

2

I would like to point out that identifiers like "[`_INTER_PREDICTION_H_`](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/inter_prediction.h#L27)" and "[`_SIMD_H`](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/simd.h#L29)" [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...

elfring

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [thor_alloc](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/simd.h#L108) - [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [main](https://github.com/cisco/thor/blob/d7f84d9e2ac0bbf226284f2f29828fccc807695f/enc/mainenc.c#L72)

elfring

Assembly optimisations - offer of code

2

Would the Thor team consider using our library of video coding assembly optimisations? This is a collection of permissively licensed assembly with test and demonstration code aimed primarily at HEVC...

kupix

Compilation errors on OMAP4 Panda board w/ ARMv7 Processor rev 2 (v7l): common/common_kernels.c: In function ‘get_inter_prediction_luma_inner’: common/common_kernels.c:197:7: error: incompatible type for argument 1 of ‘v128_unpacklo_u8_s16’ common/simd/v128_intrinsics.h:129:18: note: expected ‘v128’ but...

tmatth