openh264 icon indicating copy to clipboard operation
openh264 copied to clipboard
verified publisher icon cisco

Fix frame-decode errors.

Open tyan0 opened this issue 1 year ago • 4 comments

** This PR is re-submission of PR (#3721) to fix rebase issue. **

This pull request is for both https://github.com/cisco/openh264/issues/3710 and https://github.com/cisco/openh264/issues/3713. I am not very sure that these are the correct fixes even though the frame decode errors are indeed resolved, so please review them. Especially for https://github.com/cisco/openh264/issues/3713.

tyan0 avatar Jan 24 '24 14:01 tyan0

@BenzhengZhang ping?

joakim-tjernlund avatar May 02 '24 18:05 joakim-tjernlund

@tyan0 Is there a risk of regression?

BenzhengZhang avatar Jul 18 '24 06:07 BenzhengZhang

I cannot say that there is never a risk of regression, however, as far as I tested (with many of my video archives and the test cases of which recently reported) I have not found any regression so far.

tyan0 avatar Jul 18 '24 12:07 tyan0

@tyan0 Is there a risk of regression?

At this point I guess it would be best to merge it to master to find out.

joakim-tjernlund avatar Jul 29 '24 12:07 joakim-tjernlund

Fixed a bug reported in https://github.com/cisco/openh264/pull/3772

tyan0 avatar Aug 04 '24 13:08 tyan0