libsrtp icon indicating copy to clipboard operation
libsrtp copied to clipboard

Published 20 hours ago • verified publisher icon cisco

Add support for cryptex

Open murillo128 opened this issue 4 years ago • 21 comments

Implementation of cryptex as per https://github.com/juberti/cryptex

Discussion: https://github.com/juberti/cryptex/issues/5

murillo128 avatar Nov 05 '20 21:11 murillo128

hi, it would be good to get the CI build passing as soon as possible, are you able to fix that or doe you need some help?

pabuhler avatar Nov 09 '20 10:11 pabuhler

Great to have this on a branch but I would like to see the IETF draft to get further along before we merge it to the main branch.

fluffy avatar Dec 27 '20 16:12 fluffy

@fluffy I agree. My main intent was to get feedback on the changes and spot any issue on the implementation that could impact the spec.

Would be great if it could be thoroughly reviewed so we can confirm that the test vectors can be incorporated into the rfc and be ready to merge the branch as soon as the rfc is ready.

murillo128 avatar Dec 27 '20 16:12 murillo128

Given the IETF draft is about at WGLC, we should merge this in once we are happy with the tests.

fluffy avatar Jul 26 '21 23:07 fluffy

Given the IETF draft is about at WGLC, we should merge this in once we are happy with the tests.

@murillo128 are you able to fix the compile issues? Maybe rebase on master as well?

@paulej have you thought to review these changes ?

pabuhler avatar Aug 09 '21 17:08 pabuhler

I'll do it later this month when I am back from vacations

murillo128 avatar Aug 09 '21 18:08 murillo128

I have also rebased to master and fixed the CI errors of the previous version. Could anyone run the github workflows to check if everything is correct now?

murillo128 avatar Aug 24 '21 14:08 murillo128

fixed format and mem leak on deallocating recv sessions on tests

murillo128 avatar Aug 29 '21 10:08 murillo128

@bifurcation - Did you ever ger to look at this ?

fluffy avatar Mar 08 '22 00:03 fluffy

Yes, that's what led to this: https://github.com/juberti/cryptex/issues/31

On Mon, Mar 7, 2022 at 7:19 PM Cullen Jennings @.***> wrote:

@bifurcation https://github.com/bifurcation - Did you ever ger to look at this ?

— Reply to this email directly, view it on GitHub https://github.com/cisco/libsrtp/pull/511#issuecomment-1061275162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASOTKHLJ6J64N74CA52CDU62MJVANCNFSM4TL45Z7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

bifurcation avatar Mar 08 '22 14:03 bifurcation