NATTools

NATTools copied to clipboard

#define ⇒ enum?

1

Would you like to replace more defines for constant values by [enumerations](https://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages) to stress their relationships? - [ICELIB_…_WEIGHT](https://github.com/cisco/NATTools/blob/dadc20e10c348d1ba6de8736d71f442e88551eba/icelib/include/icelib_defines.h#L54) - [STUN_ATTR_…](https://github.com/cisco/NATTools/blob/1332849a86c9460f1e3fe0154286ecb02652d531/stunlib/include/stunlib.h#L95)

elfring

[This line](https://github.com/cisco/NATTools/blob/1332849a86c9460f1e3fe0154286ecb02652d531/stunlib/src/stunlib.c#L1589) will cause a crash when using stunlib with a `NULL` `stream` argument. i.e. `stunlib_DecodeMessage(buff, bufLen, &msg, NULL, NULL)`. Pretty much everywhere in `stunlib_DecodeMessage` is guarding on `stream !=...

clux