findcdn
findcdn copied to clipboard
ipwhois does not specify an install version, which caused tests to fail in some environments
Somehow or another, in a test environment, "ipwhois" was installed at 0.XX instead of 1.2.0.
Running setup.py on this environment caused no complaints, but inexplicably the tests failed.
If I did not run the tests first, I would have not known anything was wrong.
https://github.com/cisagov/findcdn/blob/7bbf50e4a1cf1f32999c1abdcabc064d8ebf53f8/setup.py#L93
I would suggest that:
- Tests get run on setup.py to make sure everything is actually working
- minimum version numbers are explicitly specified.