development-guide icon indicating copy to clipboard operation
development-guide copied to clipboard

Add a section about "things to keep in mind when reviewing a PR".

Open felddy opened this issue 4 years ago • 1 comments

That is a good point, although we devs tend to have a hard time knowing or remembering what normies know and don't know. It's definitely something to keep in mind when reviewing other devs' pull requests.

This triggered a thought: Should we have a document in our dev guide that talks about reviewing PRs and has a list of thangs like this to keep in mind? I think such a document could be useful, but could also turn into a list that is too long and random to be of any use. Does 18F or TTS have a document we can borrow/steal?

Originally posted by @jsf9k in https://github.com/cisagov/skeleton-docker/pull/51#r609700136

felddy avatar Apr 26 '21 16:04 felddy

Great idea!

jsf9k avatar Apr 26 '21 17:04 jsf9k