ScubaGoggles
ScubaGoggles copied to clipboard
Updates JSON Schema Fields
๐ฃ Description
Updates JSON fields from old fields to the new updated fields in order to be more consistent with ScubaGear
๐ญ Motivation and context
Closes #764
๐งช Testing
Run ScubaGoggles, check ScubaResults to see each of the 4 new columns (OriginalResult, OriginalDetails, Comments, ResolutionDate) and now there should be no OmittedEvaluationResult, OmittedEvaluationDetails, IncorrectResult, and IncorrectDetails
โ Pre-approval checklist
- [ ] This PR has an informative and human-readable title.
- [ ] Changes are limited to a single goal - eschew scope creep!
- [ ] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
- [ ] The relevant issues PR resolves are linked preferably via closing keywords.
- [ ] All relevant type-of-change labels have been added.
- [ ] I have read and agree to the CONTRIBUTING.md document.
- [ ] These code changes follow cisagov code standards.
- [ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
- [ ] Tests have been added and/or modified to cover the changes in this PR.
- [ ] All new and existing tests pass.
โ Pre-merge Checklist
- [ ] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
- [ ] Squash all commits into one PR level commit using the
Squash and mergebutton.
โ Post-merge Checklist
- [ ] Delete the branch to clean up.
- [ ] Close issues resolved by this PR if the closing keywords did not activate.
Currently the file has a linter disabler because the PR would be blocked from merge without it, but there has been an issue created to fix this issue (#831). Please ignore the linter disabler at the beginning of the file and review the rest.