LME icon indicating copy to clipboard operation
LME copied to clipboard

Determine if we should offer a way to customize docker-compose-stack-live.yml

Open llwaterhouse opened this issue 10 months ago • 2 comments

llwaterhouse avatar Apr 11 '24 21:04 llwaterhouse

Based on feedback from user in issue https://github.com/cisagov/LME/discussions/200 , we should research how to keep docker-compose customizations when the user upgrades and a new docker-compose-stack-live.yml is written by LME.

He needs to customize docker-compose-stack-live.yml so the containers use the proxy.

But the proxy commands will be lost with every update/upgrade since we rewrite docker-compose-stack-live.yml when we upgrade.

llwaterhouse avatar Apr 11 '24 21:04 llwaterhouse

I think this could be a good addition to the 2.0 build. Especially if we use something like a .env file during install we could just have an option to use a proxy server or not.

We can also instruct to use the config.json: https://docs.docker.com/network/proxy/

I do not believe this file would get touched during uninstall / reinstall of LME

Also we do provide instructions here: https://github.com/cisagov/LME/blob/fcb7199ac04bc3930211c86761cd7d6d70406b04/docs/markdown/chapter3/chapter3.md#312-web-proxy-settings

aarz-snl avatar Apr 15 '24 13:04 aarz-snl