LME icon indicating copy to clipboard operation
LME copied to clipboard

Instead of asking people to download release and unzip, look into writing script to use curl to download release and unzip files

Open llwaterhouse opened this issue 1 year ago • 4 comments

llwaterhouse avatar Jan 12 '24 20:01 llwaterhouse

Only when users download the release zip file does a "download" get counted.

Our installation instructions say to do a "git clone" of the LME repo which does not count as a download. Github does not keep track of clones.

Our current downloads may be undercounted. We also have to consider if peole download each release, should that count as a download since it's not a unique instance.

llwaterhouse avatar Jan 12 '24 20:01 llwaterhouse

Something like this could simplify the install process AND allow us to accurately track downloads:

first

sudo apt update && sudo apt install curl jq unzip -y

curl -s https://api.github.com/repos/cisagov/LME/releases/latest | jq -r '.assets[0].browser_download_url' | xargs -I {} sh -c 'curl -L -O {} && unzip -d /opt/lme/ "$(basename {})"'

This will automatically grab the latest .zip release, and unzip the files to /opt/lme

We could script this out even further and the install directions would be

' curl download this .sh and run it' and it would do all of this including chmods, and ./deploy.sh install

aarz-snl avatar Jan 12 '24 22:01 aarz-snl

This looks great!

It looks like I was confusing the installation instructions in Chapter 1 with the way I install LME myself and the "git clones" I've seen in scripts. The installation instructions actually do say to download the release.

While this is good for now, your approach would be great to incorporate when we modify Clint's InstallScript to be published for all users to use. I see that deploy.sh uses the first part of your curl command.

We need to make it clear to everyone that downloads are not unique instances.

llwaterhouse avatar Jan 12 '24 22:01 llwaterhouse

I think I will put that into my script. I don't like cloning it. Thanks, Clint Baxley @.***

Windows is great... I used it to download Linux.

On Fri, Jan 12, 2024 at 5:21 PM Linda Waterhouse @.***> wrote:

This looks great!

It looks like I was confusing the installation instructions in Chapter 1 with the way I install LME myself and the "git clones" I've seen in scripts. The installation instructions actually do say to download the release.

While this is good for now, your approach would be great to incorporate when we modify Clint's InstallScript to be published for all users to use. I see that deploy.sh uses the first part of your curl command.

We need to make it clear to everyone that downloads are not unique instances.

— Reply to this email directly, view it on GitHub https://github.com/cisagov/LME/issues/159#issuecomment-1890058951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQY33QL5GCH27LUO6WZWTLYOGZOTAVCNFSM6AAAAABBYUSH52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGA2TQOJVGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cbaxley avatar Jan 13 '24 01:01 cbaxley